Checklist for reviewers

This checklist must contain no more than 20 items. If item 21 is added remove the least significant item.

  1. There are no tabs.
  2. There are no trailing spaces.
  3. Javadocs are consistent with the code.
  4. Javadocs include the invariants (eg: null/not null for attributes).
  5. Javadocs include the preconditions (eg: null/not null for parameters).
  6. Check that all parameters are final.
  7. Make sure new clasess are created in the correct package.
  8. When reviewing a bug fix, make sure there is a test that checks for such bug.
  9. Make sure singleton classes do not hold references to non-singleton classes.